Change in osmo-ttcn3-hacks[master]: MGCP_Test: add control interface to MGW testsuite

dexter gerrit-no-reply at lists.osmocom.org
Fri Jul 16 08:19:26 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24820 )

Change subject: MGCP_Test: add control interface to MGW testsuite
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24820/1/mgw/MGCP_Test.ttcn 
File mgw/MGCP_Test.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24820/1/mgw/MGCP_Test.ttcn@150 
PS1, Line 150: 		f_ipa_ctrl_start_client(mp_remote_ipv4, mp_mgw_ctrl_port);
> do we really want to start the CTRL conn on every test? I'd leave it only for tests requiring CTRL s […]
the testsuite for bsc and msc does it the same way. I wouldn't do it differently for mgw.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24820
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7324802bf6e692ce8b7d9b269dd2385a7d3d0d77
Gerrit-Change-Number: 24820
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 16 Jul 2021 08:19:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210716/85e8d0a9/attachment.htm>


More information about the gerrit-log mailing list