Change in osmo-bsc[master]: Add new lchan_select() API helper

laforge gerrit-no-reply at lists.osmocom.org
Thu Jul 15 12:07:44 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24949 )

Change subject: Add new lchan_select() API helper
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/24949/1/src/osmo-bsc/lchan_select.c 
File src/osmo-bsc/lchan_select.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24949/1/src/osmo-bsc/lchan_select.c@317 
PS1, Line 317: lchan_select
I would prefer something like lchan_set_type() or lchan_type_set() which is very descriptive. "select" sounds like selecting a lchan from a group of lchans, like in lchan allocation.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24949
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I025a40962a5e5d40543b297a0760e47618fb525c
Gerrit-Change-Number: 24949
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 15 Jul 2021 12:07:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210715/8077bd1b/attachment.htm>


More information about the gerrit-log mailing list