Change in osmo-bsc[master]: Avoid switching dyn ts to sdcch8 if it starves later TCH

pespin gerrit-no-reply at lists.osmocom.org
Thu Jul 15 12:02:27 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24876 )

Change subject: Avoid switching dyn ts to sdcch8 if it starves later TCH
......................................................................


Patch Set 4:

(1 comment)

I submitted a couple more patches as a follow up of this one.

https://gerrit.osmocom.org/c/osmo-bsc/+/24876/4/src/osmo-bsc/abis_rsl.c 
File src/osmo-bsc/abis_rsl.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24876/4/src/osmo-bsc/abis_rsl.c@1955 
PS4, Line 1955: 	 * different TS than the one we want to switch, so we are fine selecting
> "A: the free TCH/F must be a static timeslot; B1: half occupied TCH/H TS; B2: half occupied TCH/H TS […]
"But for C, what if there are two half occupied TCH/H plus one static TCH/F?"
^ This cannot be the case, because we already know we are switching a DYN TS for SDCCH, hence it means there must be at least 1 OSMO_DYN_TS in PDCH mode. Hence, if free_tchf and free_tchh is 1 and 2, it must be that same OSMO_DYN_TS.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24876
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I3b32968949a7bdcbebf5a823359295bac51d8e08
Gerrit-Change-Number: 24876
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 15 Jul 2021 12:02:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210715/85117fed/attachment.htm>


More information about the gerrit-log mailing list