Change in osmo-bsc[master]: handover_ctrl: add control interface for handover settings

dexter gerrit-no-reply at lists.osmocom.org
Thu Jul 15 10:04:07 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24600 )

Change subject: handover_ctrl: add control interface for handover settings
......................................................................


Patch Set 8:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/24600/7/src/osmo-bsc/handover_ctrl.c 
File src/osmo-bsc/handover_ctrl.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24600/7/src/osmo-bsc/handover_ctrl.c@185 
PS7, Line 185: {
> 0) I don't understand yet where the spaces-to-dots conversion happens. […]
0) I also do not understand this, there seems to be an agreement that one has to define the commands with spaces and internally the spaces are then translated to dots. Probably this is intended so that one can re-use the lines from VTY.

1) Makes sense, saves some memory.

2) I have tried that. The space is also an illegal char and gets replaced with - and then it does not work anymore.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24600
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I12f143906818fd6b16e8783157cbb1eb51e49ffc
Gerrit-Change-Number: 24600
Gerrit-PatchSet: 8
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Assignee: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 15 Jul 2021 10:04:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210715/b1879c58/attachment.htm>


More information about the gerrit-log mailing list