Change in osmo-ci[master]: lint: checkpatch.pl: allow spaces below (g)DEFUN

osmith gerrit-no-reply at lists.osmocom.org
Thu Jul 15 08:22:54 UTC 2021


Hello pespin, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-ci/+/24918

to look at the new patch set (#2).

Change subject: lint: checkpatch.pl: allow spaces below (g)DEFUN
......................................................................

lint: checkpatch.pl: allow spaces below (g)DEFUN

Do not complain if indenting with exactly 6/7 spaces below (g)DEFUN(,
as it's often done in VTY-related code in Osmocom. This patch assumes
that if the line starts with 6/7 spaces and " or a word, it's probably
below DEFUN( or gDEFUN(. I've considered implementing a more accurate
check, but that would be too much effort (e.g. when more macros are
involved).

Other related macros, such as DEFUN_ATTR are longer. Indentation below
those should be done with one tab (+ spaces for padding), the linter
doesn't need to be adjusted for those.

Related: OS#5087
Change-Id: I0934b63a62500e7a3e09c753cc63aa331e580cc6
---
M lint/checkpatch/checkpatch.pl
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/18/24918/2
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/24918
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I0934b63a62500e7a3e09c753cc63aa331e580cc6
Gerrit-Change-Number: 24918
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210715/436bf026/attachment.htm>


More information about the gerrit-log mailing list