Change in libosmocore[master]: vty: add "show uptime"

laforge gerrit-no-reply at lists.osmocom.org
Wed Jul 14 19:25:33 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24924 )

Change subject: vty: add "show uptime"
......................................................................


Patch Set 2: Code-Review-1

why are we using time() here when everywhere else we (rightfully) use clock_gettime()?

We don't care about the system RTC time (whcih may be wrong at boot and later corrected manually or via ntp).  What we care about is the delta.  Using time() will produce completely random results if the RTC changes at any time during the application execution.

clock_gettime with CLOCK_MONOTONIC should be doing a much better job.


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24924
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic7d9d5d3c8a9abd06a7e626aed7679f68406040c
Gerrit-Change-Number: 24924
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Jul 2021 19:25:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210714/9175a3fa/attachment.htm>


More information about the gerrit-log mailing list