Change in osmo-bsc[master]: hodec2: add low-rxqual-assignment penalty timer (2/2)

daniel gerrit-no-reply at lists.osmocom.org
Wed Jul 14 10:06:11 UTC 2021


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24937 )

Change subject: hodec2: add low-rxqual-assignment penalty timer (2/2)
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/24937/1/src/osmo-bsc/handover_decision_2.c 
File src/osmo-bsc/handover_decision_2.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24937/1/src/osmo-bsc/handover_decision_2.c@1426 
PS1, Line 1426: 		}
Should you return rc here? Right now this will always fall-through to the log line below which seems unintentional.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24937
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id00a07313fe04eec509b336c0637b59c707760e0
Gerrit-Change-Number: 24937
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Jul 2021 10:06:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210714/61cf7946/attachment.htm>


More information about the gerrit-log mailing list