Change in osmo-mgw[master]: mgcp_trunk: add value string for trunk type.

daniel gerrit-no-reply at lists.osmocom.org
Wed Jul 14 09:23:13 UTC 2021


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24928 )

Change subject: mgcp_trunk: add value string for trunk type.
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/24928/1/include/osmocom/mgcp/mgcp_trunk.h 
File include/osmocom/mgcp/mgcp_trunk.h:

https://gerrit.osmocom.org/c/osmo-mgw/+/24928/1/include/osmocom/mgcp/mgcp_trunk.h@18 
PS1, Line 18: { return get_value_string(mgcp_trunk_type_strs, val); }
I don't really like this formatting - even if the function is just a one-liner. Not going to argue about it, though.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24928
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I634fb2a03744117e976430468ab5c57d50ab0089
Gerrit-Change-Number: 24928
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Jul 2021 09:23:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210714/d5fcc974/attachment.htm>


More information about the gerrit-log mailing list