Change in osmo-mgw[master]: mgcp_ratectr: refactor rate counter and set group name

pespin gerrit-no-reply at lists.osmocom.org
Tue Jul 13 12:34:36 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24929 )

Change subject: mgcp_ratectr: refactor rate counter and set group name
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/24929/1/src/libosmo-mgcp/mgcp_ratectr.c 
File src/libosmo-mgcp/mgcp_ratectr.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/24929/1/src/libosmo-mgcp/mgcp_ratectr.c@198 
PS1, Line 198: 		snprintf(ctr_name, sizeof(ctr_name), "%s-%i:crcx", mgcp_trunk_type_strs_str(trunk->trunk_type),
we usually use %d in osmocom code (see below too).



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24929
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I5e7f0e9081a06af48e284afa5c36a095b2847704
Gerrit-Change-Number: 24929
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 13 Jul 2021 12:34:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210713/c7095a93/attachment.htm>


More information about the gerrit-log mailing list