This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24926 ) Change subject: vty: add "shutdown" ...................................................................... Patch Set 2: > Patch Set 2: > > > Patch Set 1: > > > > Why not simply sending some signal() to the process itself and let usual SIGINT or alike take the usual exit path? > > I've tried it, but found that it doesn't nicely service the pending writes before quitting, at least with the programs I've tested. So I did a combination of both that doesn't need setting the variable in every loop. I would really avoid having a separate shutdown procedure/steps done when triggering by VTY. If the app doesn't support proper shutdown in usual case, I think it's dangerous doing so through VTY. So I'd vote for going the way I mentioned (sending signal SIGTERM or similar), and if specific apps don't behave as expected, then fix the usual shutdown path (SIGTERM or alike, usually sent by user or systemd). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24926 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3596a35b0f4a24e49484ec3f24a98e4d4f583e1e Gerrit-Change-Number: 24926 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 13 Jul 2021 11:30:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210713/19785526/attachment.htm>