This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24917 ) Change subject: bsc: fix encryption a5/4 missing in TC_*_a5_4 ...................................................................... bsc: fix encryption a5/4 missing in TC_*_a5_4 After removing a5/4 from the default config, it also needs to be explicitly enabled for these two tests. Fixes: 26a3db ("bsc: change encryption a5 via VTY where needed") Change-Id: Ibe00edb096f94b500869c46a39a694a73133c716 --- M bsc/BSC_Tests.ttcn 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve neels: Looks good to me, approved diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 2a89659..97ec4c6 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -3479,9 +3479,11 @@ pars.encr := valueof(t_EncrParams('10'O, f_rnd_octstring(8), f_rnd_octstring(16))); f_init(1, true); + f_vty_encryption_a5("0 1 3 4"); f_sleep(1.0); vc_conn := f_start_handler(refers(f_tc_assignment_fr_a5), pars); vc_conn.done; + f_vty_encryption_a5_reset(); f_shutdown_helper(); } @@ -4816,12 +4818,13 @@ f_shutdown_helper(); } -function f_tc_ho_int_a5(OCT1 encr_alg) runs on test_CT { +function f_tc_ho_int_a5(OCT1 encr_alg, charstring enc_a5 := "0 1 3") runs on test_CT { var MSC_ConnHdlr vc_conn; var TestHdlrParams pars := f_gen_test_hdlr_pars(); pars.encr := valueof(t_EncrParams(encr_alg, f_rnd_octstring(8), f_rnd_octstring(16))); f_init(2, true); + f_vty_encryption_a5(enc_a5); f_sleep(1.0); f_ctrs_bsc_and_bts_init(); @@ -4838,6 +4841,7 @@ f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:attempted"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:completed"); f_ctrs_bsc_and_bts_verify(); + f_vty_encryption_a5_reset(); f_shutdown_helper(); } @@ -4854,7 +4858,7 @@ } testcase TC_ho_int_a5_4() runs on test_CT { - f_tc_ho_int_a5('10'O); + f_tc_ho_int_a5('10'O, "0 1 3 4"); } /* intra-BSC hand-over with CONNection FAILure and cause Radio Link Failure: check RR release cause */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24917 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibe00edb096f94b500869c46a39a694a73133c716 Gerrit-Change-Number: 24917 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210712/4a6f88b0/attachment.htm>