Change in libosmo-sccp[master]: m3ua: fix leaky usage of m3ua_tx_xua_asp

neels gerrit-no-reply at lists.osmocom.org
Mon Jul 12 14:24:46 UTC 2021


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/24909 )

Change subject: m3ua: fix leaky usage of m3ua_tx_xua_asp
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

indeed fixes the leaks that i reported

https://gerrit.osmocom.org/c/libosmo-sccp/+/24909/2/src/m3ua.c 
File src/m3ua.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/24909/2/src/m3ua.c@757 
PS2, Line 757: 		xua_msg_free(err);
with this change applied, i still see this after running a few BSC ttcn3 tests:

==1994==ERROR: LeakSanitizer: detected memory leaks

Indirect leak of 11760 byte(s) in 90 object(s) allocated from:
    #0 0x7fbec8de6330 in __interceptor_malloc (/lib/x86_64-linux-gnu/libasan.so.5+0xe9330)
    #1 0x7fbec899f140 in _talloc_zero (/lib/x86_64-linux-gnu/libtalloc.so.2+0x9140)

Indirect leak of 6000 byte(s) in 60 object(s) allocated from:
    #0 0x7fbec8de6330 in __interceptor_malloc (/lib/x86_64-linux-gnu/libasan.so.5+0xe9330)
    #1 0x7fbec899f776 in _talloc_memdup (/lib/x86_64-linux-gnu/libtalloc.so.2+0x9776)

SUMMARY: AddressSanitizer: 17760 byte(s) leaked in 150 allocation(s).


https://gerrit.osmocom.org/c/libosmo-sccp/+/24909/2/src/m3ua.c@861 
PS2, Line 861: 	xua_msg_free(xua);
with this change applied, all of the above asan error messages are gone



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/24909
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Id8584b99f30f2db602d4d129e4114821697272ab
Gerrit-Change-Number: 24909
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 12 Jul 2021 14:24:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210712/9fa1bfde/attachment.htm>


More information about the gerrit-log mailing list