This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/24869 ) Change subject: lint: checkpatch.pl: fix && complaints ...................................................................... lint: checkpatch.pl: fix && complaints Don't complain with: ERROR:SPACING: space prohibited after that '&&' (ctx:ExW) in code similar to: if (conn->conn->mode != MGCP_CONN_LOOPBACK && conn->conn->mode != MGCP_CONN_RECV_ONLY && !mgcp_rtp_end_remote_addr_available(&conn->end)) { The check was supposed to complain about spaces if the && is used as unary operator (to get the address of a goto label). But it's clearly producing false positives in the Osmocom context with use as non-unary operator, so remove this check. Related: OS#5087 Related: https://github.com/torvalds/linux/commit/0d413866c7df63794790518e3fd5890969c206ad Change-Id: I7ce79e6b291b3a3dab6587a589eeef0a0bc53de9 --- M lint/checkpatch/checkpatch.pl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved; Verified diff --git a/lint/checkpatch/checkpatch.pl b/lint/checkpatch/checkpatch.pl index dc56812..ad99e0c 100755 --- a/lint/checkpatch/checkpatch.pl +++ b/lint/checkpatch/checkpatch.pl @@ -5072,7 +5072,7 @@ # unary operator, or a cast } elsif ($op eq '!' || $op eq '~' || $opv eq '*U' || $opv eq '-U' || - $opv eq '&U' || $opv eq '&&U') { + $opv eq '&U') { # Osmocom specific: &&U removed if ($ctx !~ /[WEBC]x./ && $ca !~ /(?:\)|!|~|\*|-|\&|\||\+\+|\-\-|\{)$/) { if (ERROR("SPACING", "space required before that '$op' $at\n" . $hereptr)) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/24869 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7ce79e6b291b3a3dab6587a589eeef0a0bc53de9 Gerrit-Change-Number: 24869 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210711/7a96c3a8/attachment.htm>