Change in osmo-ci[master]: lint: ignore LINE_CONTINUATIONS

laforge gerrit-no-reply at lists.osmocom.org
Sun Jul 11 17:44:47 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/24868 )

Change subject: lint: ignore LINE_CONTINUATIONS
......................................................................

lint: ignore LINE_CONTINUATIONS

Causes false positives, e.g. in tests/mgcp/mgcp_test.c in osmo-mgw:

  #define MDCX4_PT2 \
	"MDCX 18983218 1 at mgw MGCP 1.0\r\n" \
	"M: sendrecv\r" \
	"C: 2\r\n" \
	"I: %s\r\n" \
	"L: p:20-20, a:AMR, nt:IN\r\n" \
	...

tests/mgcp/mgcp_test.c:189: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations

Related: OS#5087
Change-Id: I8d8004f2a8ef926588487187af7cdef8254c7248
---
M lint/checkpatch/checkpatch_osmo.sh
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  pespin: Looks good to me, but someone else must approve
  dexter: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved; Verified



diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh
index 75fef8e..1932c03 100755
--- a/lint/checkpatch/checkpatch_osmo.sh
+++ b/lint/checkpatch/checkpatch_osmo.sh
@@ -18,6 +18,7 @@
 # * GLOBAL_INITIALISERS: we initialise globals to NULL for talloc ctx (e.g. *tall_lapd_ctx = NULL)
 # * IF_0: used intentionally
 # * INITIALISED_STATIC: we use this, see also http://lkml.iu.edu/hypermail/linux/kernel/0808.1/2235.html
+# * LINE_CONTINUATIONS: false positives
 # * LINE_SPACING: we don't always put a blank line after declarations
 # * REPEATED_WORD: false positives in doxygen descriptions (e.g. '\param[in] data Data passed through...')
 # * SPDX_LICENSE_TAG: we don't place it on line 1
@@ -39,6 +40,7 @@
 	--ignore GLOBAL_INITIALISERS \
 	--ignore IF_0 \
 	--ignore INITIALISED_STATIC \
+	--ignore LINE_CONTINUATIONS \
 	--ignore LINE_SPACING \
 	--ignore REPEATED_WORD \
 	--ignore SPDX_LICENSE_TAG \

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/24868
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I8d8004f2a8ef926588487187af7cdef8254c7248
Gerrit-Change-Number: 24868
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210711/a783a065/attachment.htm>


More information about the gerrit-log mailing list