Change in osmo-ci[master]: lint: ignore COMPLEX_MACRO

laforge gerrit-no-reply at lists.osmocom.org
Sun Jul 11 17:44:47 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/24867 )

Change subject: lint: ignore COMPLEX_MACRO
......................................................................

lint: ignore COMPLEX_MACRO

Complains about, for example:
  #define MDCX4 \
	"MDCX 18983217 1 at mgw MGCP 1.0\r\n" \
	"M: sendrecv\r" \
	"C: 2\r\n" \
	"I: %s\r\n" \
	"L: p:20, a:AMR, nt:IN\r\n" \
	"\n" \
	"v=0\r\n" \
	"o=- %s 23 IN IP4 5.6.7.8\r\n" \
	"c=IN IP4 5.6.7.8\r\n" \
	"t=0 0\r\n" \
	"m=audio 4441 RTP/AVP 99\r\n" \
	"a=rtpmap:99 AMR/8000\r\n" \
	"a=ptime:40\r\n"

Related: OS#5087
Change-Id: Ic9d752ca841161a62e3631c84b4237a0d8594363
---
M lint/checkpatch/checkpatch_osmo.sh
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved; Verified



diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh
index b98e98b..75fef8e 100755
--- a/lint/checkpatch/checkpatch_osmo.sh
+++ b/lint/checkpatch/checkpatch_osmo.sh
@@ -9,6 +9,7 @@
 # * ASSIGN_IN_IF: not followed (e.g. 'if ((u8 = gsup_msg->cause))')
 # * AVOID_EXTERNS: we do use externs
 # * BLOCK_COMMENT_STYLE: we don't use a trailing */ on a separate line
+# * COMPLEX_MACRO: we don't use parentheses when building macros of strings across multiple lines
 # * CONSTANT_COMPARISON: not followed: "Comparisons should place the constant on the right side"
 # * EMBEDDED_FUNCTION_NAME: often __func__ isn't used, arguably not much benefit in changing this when touching code
 # * EXECUTE_PERMISSIONS: not followed, files need to be executable: git-version-gen, some in debian/
@@ -29,6 +30,7 @@
 	--ignore ASSIGN_IN_IF \
 	--ignore AVOID_EXTERNS \
 	--ignore BLOCK_COMMENT_STYLE \
+	--ignore COMPLEX_MACRO \
 	--ignore CONSTANT_COMPARISON \
 	--ignore EMBEDDED_FUNCTION_NAME \
 	--ignore EXECUTE_PERMISSIONS \

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/24867
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ic9d752ca841161a62e3631c84b4237a0d8594363
Gerrit-Change-Number: 24867
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210711/184421c1/attachment.htm>


More information about the gerrit-log mailing list