Change in osmo-bsc[master]: RES IND: parse msg and store interference levels in lchans

fixeria gerrit-no-reply at lists.osmocom.org
Sun Jul 11 04:52:19 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24883 )

Change subject: RES IND: parse msg and store interference levels in lchans
......................................................................


Patch Set 3:

(3 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/24883/3/src/osmo-bsc/abis_rsl.c 
File src/osmo-bsc/abis_rsl.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24883/3/src/osmo-bsc/abis_rsl.c@1489 
PS3, Line 1489: ts
Cosmetic: I would make this pointer scoped, it's not used outside of the loop.


https://gerrit.osmocom.org/c/osmo-bsc/+/24883/3/src/osmo-bsc/abis_rsl.c@1498 
PS3, Line 1498: 		LOGP(DRSL, LOGL_ERROR, "Rx Resource Indication: missing Resource Info IE\n");
Older versions of osmo-bts actually do send the RF RESource INDication without this IE (violating the specs). But this happens only once after the RSL connection establishment, after that no more RESource INDication messages are sent to the BSC. Just FYI.


https://gerrit.osmocom.org/c/osmo-bsc/+/24883/3/src/osmo-bsc/abis_rsl.c@1524 
PS3, Line 1524: lchan->ts->trx->bts
You already have the 'trx' pointer, so you could do 'trx->bts' below.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24883
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iccc1391e8419604bb09e464db8455e053dfbc982
Gerrit-Change-Number: 24883
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Sun, 11 Jul 2021 04:52:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210711/fbc99e57/attachment.htm>


More information about the gerrit-log mailing list