This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24873 ) Change subject: mgcp_protocol: fix loop that sends dummy RTP packets ...................................................................... mgcp_protocol: fix loop that sends dummy RTP packets The logic in mgcp_keepalive_timer_cb() only sends dummy packets for endpoints 1-N, leaving out endpoint 0, this is not correct it should include all endpoints (0-N). Change-Id: I99a9b572eac26780bc1286a8dd63c4c5652fda4f --- M src/libosmo-mgcp/mgcp_protocol.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index 56271e2..29d27d4 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -1494,7 +1494,7 @@ /* Send walk over all endpoints and send out dummy packets through * every connection present on each endpoint */ - for (i = 1; i < trunk->number_endpoints; ++i) { + for (i = 0; i < trunk->number_endpoints; ++i) { struct mgcp_endpoint *endp = trunk->endpoints[i]; llist_for_each_entry(conn, &endp->conns, entry) { if (conn->type == MGCP_CONN_TYPE_RTP && -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24873 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I99a9b572eac26780bc1286a8dd63c4c5652fda4f Gerrit-Change-Number: 24873 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210709/50f98f8d/attachment.htm>