Change in osmo-bsc[master]: lchan_fsm: Improve timeout logging line in state WAIT_RLL_RTP_ESTABLISH

pespin gerrit-no-reply at lists.osmocom.org
Fri Jul 9 11:32:40 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24890 )

Change subject: lchan_fsm: Improve timeout logging line in state WAIT_RLL_RTP_ESTABLISH
......................................................................

lchan_fsm: Improve timeout logging line in state WAIT_RLL_RTP_ESTABLISH

This allows quickly finding out whether the timeout is happening due to
RLL not established or whether RTP is not ready. In essence, it
indicates whether issue may be coming from MGW or from MS/BTS side.

If coming from MGW, the timer T3101 is in general not a problem and the
issue should be related to some misbehaving.
If coming from MS/BTS, T3101 may require tunning (it could be a
misbehaving of the MS/BTS too, or simply bad signal).

Related: SYS#5526
Change-Id: Ib655f71aec584962c70d84a4405d996505dff53c
---
M src/osmo-bsc/lchan_fsm.c
1 file changed, 8 insertions(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  dexter: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c
index e3b6c83..841415f 100644
--- a/src/osmo-bsc/lchan_fsm.c
+++ b/src/osmo-bsc/lchan_fsm.c
@@ -1712,7 +1712,14 @@
 		lchan->release.in_error = true;
 		lchan->release.rsl_error_cause = RSL_ERR_INTERWORKING;
 		lchan->release.rr_cause = bsc_gsm48_rr_cause_from_rsl_cause(lchan->release.rsl_error_cause);
-		lchan_fail("Timeout");
+		if (fi->state  == LCHAN_ST_WAIT_RLL_RTP_ESTABLISH) {
+			lchan_fail("Timeout (rll_ready=%s,voice_require=%s,voice_ready=%s)",
+				   (lchan->sapis[0] != LCHAN_SAPI_UNUSED) ? "yes" : "no",
+				   lchan->activate.info.requires_voice_stream ? "yes" : "no",
+				   lchan_rtp_established(lchan) ? "yes" : "no");
+		} else {
+			 lchan_fail("Timeout");
+		}
 		return 0;
 	}
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24890
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib655f71aec584962c70d84a4405d996505dff53c
Gerrit-Change-Number: 24890
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210709/06e503af/attachment.htm>


More information about the gerrit-log mailing list