Change in osmo-bsc[master]: vty 'interference-meas level-bounds': explain duality in ordering

neels gerrit-no-reply at lists.osmocom.org
Thu Jul 8 18:19:58 UTC 2021


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24888 )

Change subject: vty 'interference-meas level-bounds': explain duality in ordering
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/24888/1/src/osmo-bsc/bsc_vty.c 
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24888/1/src/osmo-bsc/bsc_vty.c@5011 
PS1, Line 5011: 	      "Interference level Boundaries. 3GPP do not specify whether these should be in ascending or descending"
> This looks too much to be put in the description imho. […]
in my opinion those vty doc strings do not need to be short at all.
it is printed fine in the vty reference PDF as well as in telnet VTY doc.

I've added long descriptions in various other places already, IMHO this is
appropriate and desirable where they answer questions that the user
needs to understand to use the config item properly.


https://gerrit.osmocom.org/c/osmo-bsc/+/24888/3/tests/interf_meas.vty 
File tests/interf_meas.vty:

https://gerrit.osmocom.org/c/osmo-bsc/+/24888/3/tests/interf_meas.vty@15 
PS3, Line 15:   level-bounds  Interference level Boundaries. 3GPP do not specify whether these should be in ascending or descending order (3GPP TS 48.058 9.3.21 / 3GPP TS 52.021 9.4.25). OsmoBSC supports either ordering, but possibly some BTS models only return meaningful interference levels with one specific ordering.
and BTW the telnet VTY nicely inserts line breaks according to terminal size (not possible in these transcript tests, hence the huge line width that does not occur in practice)

In the field, it looks like this:

 OsmoBSC(config-net-bts)# interference-meas 
  avg-period    Averaging period (Intave)
  level-bounds  Interference level Boundaries. 3GPP do not specify whether
                these should be in ascending or descending order (3GPP TS
                48.058 9.3.21 / 3GPP TS 52.021 9.4.25). OsmoBSC supports
                either ordering, but possibly some BTS models only return
                meaningful interference levels with one specific ordering.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24888
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If71e20e95d29e7f03739ee04e1ef429bf8bd51ed
Gerrit-Change-Number: 24888
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 08 Jul 2021 18:19:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210708/7e769589/attachment.htm>


More information about the gerrit-log mailing list