Change in osmo-bsc[master]: lchan_fsm: Allow rx LCHAN_EV_RLL_REL_IND in WAIT_RF_RELEASE_ACK

pespin gerrit-no-reply at lists.osmocom.org
Thu Jul 8 18:08:05 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24853 )

Change subject: lchan_fsm: Allow rx LCHAN_EV_RLL_REL_IND in WAIT_RF_RELEASE_ACK
......................................................................

lchan_fsm: Allow rx LCHAN_EV_RLL_REL_IND in WAIT_RF_RELEASE_ACK

As seen in osmo-bsc log during heavy load scenario:
<000f> abis_rsl.c:2171 lchan(12-2-6-TCH_H-0)[0x559b880d1f40]{WAIT_RF_RELEASE_ACK}: Event LCHAN_EV_RLL_REL_IND not permitted

Related: SYS#5523
Change-Id: Ie307872851490ae4d60c8117a5f4e2d8c2a414d6
---
M src/osmo-bsc/lchan_fsm.c
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  daniel: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c
index 6350481..e3b6c83 100644
--- a/src/osmo-bsc/lchan_fsm.c
+++ b/src/osmo-bsc/lchan_fsm.c
@@ -1349,6 +1349,13 @@
 		/* ignore late lchan_rtp_fsm release events */
 		return;
 
+	case LCHAN_EV_RLL_REL_IND:
+		/* let's just ignore this.  We are already logging the fact
+		 * that this message was received inside abis_rsl.c. There can
+		 * be any number of reasons why the radio link layer failed.
+		 */
+		return;
+
 	default:
 		OSMO_ASSERT(false);
 	}
@@ -1594,6 +1601,7 @@
 		.action = lchan_fsm_wait_rf_release_ack,
 		.in_event_mask = 0
 			| S(LCHAN_EV_RSL_RF_CHAN_REL_ACK)
+			| S(LCHAN_EV_RLL_REL_IND) /* ignore late REL_IND of SAPI[0] */
 			| S(LCHAN_EV_RTP_RELEASED) /* ignore late lchan_rtp_fsm release events */
 			,
 		.out_state_mask = 0

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24853
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie307872851490ae4d60c8117a5f4e2d8c2a414d6
Gerrit-Change-Number: 24853
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210708/faba9da1/attachment.htm>


More information about the gerrit-log mailing list