Change in osmo-mgw[master]: mgcp_protocol: fix loop that sends dummy RTP packets

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Thu Jul 8 10:40:05 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24873 )

Change subject: mgcp_protocol: fix loop that sends dummy RTP packets
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> I guess you verified from MGCP point of view that makes sense. For instance if endp 0 can be accesses by MGCP and that we are indeed using it.

I have checked that back. The first endpoint you get is indeed rtpbridge/1 at mgw. but this endpoint has the index 0 in this array. The endpoint name and the index of the array are not directly corresponding anmore. The endpoint name is a string and the selection goes by that string, not by the array index.

(it was very annoying to allocate an endpoint at index 0 that is then never used because everything starts from index 1)

So everything is ok I think.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24873
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I99a9b572eac26780bc1286a8dd63c4c5652fda4f
Gerrit-Change-Number: 24873
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 08 Jul 2021 10:40:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210708/52333496/attachment.htm>


More information about the gerrit-log mailing list