Change in osmo-mgw[master]: mgcp_protocol: fix loop that sends dummy RTP packets
gerrit-no-reply at lists.osmocom.org
Thu Jul 8 10:40:05 UTC 2021
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24873 )
Change subject: mgcp_protocol: fix loop that sends dummy RTP packets
Patch Set 1:
> Patch Set 1:
> I guess you verified from MGCP point of view that makes sense. For instance if endp 0 can be accesses by MGCP and that we are indeed using it.
I have checked that back. The first endpoint you get is indeed rtpbridge/1 at mgw. but this endpoint has the index 0 in this array. The endpoint name and the index of the array are not directly corresponding anmore. The endpoint name is a string and the selection goes by that string, not by the array index.
(it was very annoying to allocate an endpoint at index 0 that is then never used because everything starts from index 1)
So everything is ok I think.
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24873
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 08 Jul 2021 10:40:05 +0000
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log