Change in osmo-bsc[master]: hodec2: [1/2] implement automatic choice between FULL and SUBSET meas...

neels gerrit-no-reply at lists.osmocom.org
Wed Jul 7 21:36:36 UTC 2021


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24850 )

Change subject: hodec2: [1/2] implement automatic choice between FULL and SUBSET measurements
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/24850/4/include/osmocom/bsc/meas_rep.h 
File include/osmocom/bsc/meas_rep.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/24850/4/include/osmocom/bsc/meas_rep.h@55 
PS4, Line 55: 	TDMA_MEAS_FIELD_RXLEV = 0,
> Not sure what do you win with last version change. […]
well in that MUX macro, I compose the switch() value using '<< 1' and '<< 2'.
That only works when the values used are exactly 1-bit in range.
The AUTO one never gets used in the MUX so i don't care about its value.

(I should prolly add an osmo_static_assert() for this too)


https://gerrit.osmocom.org/c/osmo-bsc/+/24850/4/src/osmo-bsc/meas_rep.c 
File src/osmo-bsc/meas_rep.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24850/4/src/osmo-bsc/meas_rep.c@86 
PS4, Line 86: #define MUX(FIELD, DIR, SET) ((FIELD) + ((DIR) << 1) + ((SET) << 2))
... this MUX here



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24850
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I283e03126a6bc1f5f1b35f9801e841053edd2947
Gerrit-Change-Number: 24850
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 07 Jul 2021 21:36:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210707/2583794a/attachment.htm>


More information about the gerrit-log mailing list