Change in osmo-mgw[master]: mgcp_send_dummy: Check RTP destination is available before attempt tx

dexter gerrit-no-reply at lists.osmocom.org
Wed Jul 7 12:52:37 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24861 )

Change subject: mgcp_send_dummy: Check RTP destination is available before attempt tx
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/24861/2/src/libosmo-mgcp/mgcp_network.c 
File src/libosmo-mgcp/mgcp_network.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/24861/2/src/libosmo-mgcp/mgcp_network.c@1044 
PS2, Line 1044: 		goto failed;
In the commit message you say that you want to make debugging easiert, Maybe the error message should then be different so that it ends up in the log that there was something wrong with the destination?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24861
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Iee6ac1f4d24c131e3bf40c37e6fdc252e5208ec8
Gerrit-Change-Number: 24861
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Wed, 07 Jul 2021 12:52:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210707/6a05f8d4/attachment.htm>


More information about the gerrit-log mailing list