This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24823 ) Change subject: mgcp_protocol: add support for wildcarded DLCX ...................................................................... Patch Set 4: (2 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/24823/2/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/24823/2/src/libosmo-mgcp/mgcp_protocol.c@1278 PS2, Line 1278: if (!endp->wildcarded_req && llist_count(&endp->conns) <= 0) { > Done You just changed the condition syntax, but not the logic here. Of course "<= 0" is the same as "< 1". What I mean is: can llist_count return less than 0? I don't think so, so using "!= 0" would be more clear here. Moreover, llist_count() requires iterating the whole list. This is not needed here. Simply check !llist_empty() which is constant in algorithmic complexity. https://gerrit.osmocom.org/c/osmo-mgw/+/24823/2/src/libosmo-mgcp/mgcp_protocol.c@1350 PS2, Line 1350: return create_ok_response(endp, 200, "DLCX", p->trans); > The endp is still there, it just got rid of all its connected and the state is reset. […] So if the request does not refer to a specific endpoint, which endpoint is selected and passed as "endp" in function handle_delete_con? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24823 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I0770cf46d93ab09efe9cafdd56d2e3f1132db189 Gerrit-Change-Number: 24823 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <nhofmeyr at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 07 Jul 2021 12:09:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Comment-In-Reply-To: dexter <pmaier at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210707/0d10c3ff/attachment.htm>