Change in osmo-mgw[master]: mgcp_ctrl: add functions to inspect trunk usage

pespin gerrit-no-reply at lists.osmocom.org
Wed Jul 7 09:05:57 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24822 )

Change subject: mgcp_ctrl: add functions to inspect trunk usage
......................................................................


Patch Set 2:

(1 comment)

So I think both Neels and I have the feeling osmo_stat probably fits better than using the CTRL interface for this purpose, am I wrong? Other opinions welcome.

>From dexter: "This is needed for TTCN3 testing. Would osmo_stat work with that. Also this is not a rate counter, this is a fixed value at a certain point in time."

That's what osmo_stat_item are for, to provide information of a fixed value at a certain point in time. That's what we use for instance to provide information about how many logical channels are in use, how many are available, etc. So same can be done here imho.

https://gerrit.osmocom.org/c/osmo-mgw/+/24822/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-mgw/+/24822/1//COMMIT_MSG@11 
PS1, Line 11: operators to monitor the MGW usage and also simplifies TTCN3 tests
> Its more for testing with TTCN3, at least that is what I need it for. […]
well, rate_ctr are for tate counters, and osmo_stats are for stats ;)

Both are available through statsd and also can be checked by TTCN3, we already have APIs there and tests using it to validate the values.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24822
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ib8b5a6e733f521828647742085cad8eccb3e715b
Gerrit-Change-Number: 24822
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Wed, 07 Jul 2021 09:05:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210707/9276b48a/attachment.htm>


More information about the gerrit-log mailing list