Change in osmo-mgw[master]: mgcp_ctrl: add functions to inspect trunk usage

dexter gerrit-no-reply at lists.osmocom.org
Wed Jul 7 08:39:57 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24822 )

Change subject: mgcp_ctrl: add functions to inspect trunk usage
......................................................................


Patch Set 1:

(3 comments)

> Patch Set 1: Code-Review+1
> 
> I'm not against this patch, but I just wonder whether it'd make more sense to have this as osmo_stat instead?

This is needed for TTCN3 testing. Would osmo_stat work with that. Also this is not a rate counter, this is a fixed value at a certain point in time.

https://gerrit.osmocom.org/c/osmo-mgw/+/24822/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-mgw/+/24822/1//COMMIT_MSG@10 
PS1, Line 10: endpoints and of the number of endpoints
> not forgetting the number of endpoints
Done


https://gerrit.osmocom.org/c/osmo-mgw/+/24822/1//COMMIT_MSG@11 
PS1, Line 11: operators to monitor the MGW usage and also simplifies TTCN3 tests
> (monitoring: wouldn't that be via stats exporting?)
Its more for testing with TTCN3, at least that is what I need it for. I don't know much about the stats exporting, but isn't that something that is more or less intended to monitor rates using rate counters. What I need here is an exact snapshot.


https://gerrit.osmocom.org/c/osmo-mgw/+/24822/1/src/libosmo-mgcp/mgcp_ctrl.c 
File src/libosmo-mgcp/mgcp_ctrl.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/24822/1/src/libosmo-mgcp/mgcp_ctrl.c@48 
PS1, Line 48: CTRL_CMD_DEFINE_RO(endpoint_count, "endpoint_count");
> what's the dif between endpoint_usage and endpoint_count?
endpoint_count returns the number of totally available endpoints. Its of course a fixed number that is set via config file (not possible for E1 trunks). I thought it would make sense to have that but I don't need it in my TTCN3 test.

Do you have an idea for a better name?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24822
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ib8b5a6e733f521828647742085cad8eccb3e715b
Gerrit-Change-Number: 24822
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Wed, 07 Jul 2021 08:39:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210707/ed22046c/attachment.htm>


More information about the gerrit-log mailing list