Change in osmo-mgw[master]: mgcp_send_dummy: Check RTP destination is available before attempt tx

pespin gerrit-no-reply at lists.osmocom.org
Tue Jul 6 18:26:50 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24861 )

Change subject: mgcp_send_dummy: Check RTP destination is available before attempt tx
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/24861/1/tests/mgcp/mgcp_test.ok 
File tests/mgcp/mgcp_test.ok:

https://gerrit.osmocom.org/c/osmo-mgw/+/24861/1/tests/mgcp/mgcp_test.ok@121 
PS1, Line 121: 
> why is this logging changed? I don't comprehend how this happens, and i'd like to understand that it […]
because in osmo-mgw we are no longer calling sendto() with invalid ip addr and port. The dummy packets count is incremented by a function overriding "sendto()" in the test. Since in those cases the count is 0, nothing is printed. In other tests under this same file dummy packets still appear.

So, in summary, these lines not being printed anymore mean that the issue is being fixed and we are not calling sendto() with invalid data.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24861
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Iee6ac1f4d24c131e3bf40c37e6fdc252e5208ec8
Gerrit-Change-Number: 24861
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Tue, 06 Jul 2021 18:26:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210706/5748d9b4/attachment.htm>


More information about the gerrit-log mailing list