Change in osmo-mgw[master]: mgw: rx CRCX: Avoid sending dummy rtp if remote address not provided
gerrit-no-reply at lists.osmocom.org
Tue Jul 6 17:08:34 UTC 2021
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
to look at the new patch set (#2).
Change subject: mgw: rx CRCX: Avoid sending dummy rtp if remote address not provided
mgw: rx CRCX: Avoid sending dummy rtp if remote address not provided
The following sequence of events was seen frequently in a osmo-mgw
instance running on the field with heavy traffic:
endpoint:rtpbridge/1 at mgw CRCX: creating new connection ...
mgcp_network.c:236 endpoint:rtpbridge/1 at mgw CI:1C8CCFA9 Failed to send dummy RTP packet.
Allegedly, that happens because at CRCX time the remote address may
still not be known, hence we end up trying to send a dummy rtp packet
to, for instance, host 0.0.0.0 port 0, which will of course fail.
Let's avoid sending it if the address is not yet known.
Similary, same issue could be seen during MDCX, since at MDCX we don't
necessarily need to have a valid addr+port (there could be several MDCX
and only last one set it).
Finally, the keepalive timer also needs the check, since it iterates
over all connections, and it could be that some is still not fully
3 files changed, 13 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/62/24862/2
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24862
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log