Change in osmo-bts[master]: Do not transmit dummy RLC/MAC blocks on non-BCCH carriers

pespin gerrit-no-reply at
Tue Jul 6 10:07:52 UTC 2021

pespin has posted comments on this change. ( )

Change subject: Do not transmit dummy RLC/MAC blocks on non-BCCH carriers

Patch Set 1: Code-Review-1

Commit Message: 
PS1, Line 11: if a PDCH timeslot has no Uplink nor Downlink TBFs allocated, then (most
Dummy blocks can still be sent on DL if there's a TBF available, and they serve a purpose in that case. 
File include/osmo-bts/pcuif_proto.h: 
PS1, Line 72: #define PCU_IF_DATA_F_DUMMY		(1 << 0)
As I mentioned on the other patch, this naming/(description should be changed. 
File src/common/pcu_sock.c: 
PS1, Line 694: 		 * carriers if the PCU indicates that no TBFs are active at the moment. */
"if the PCU indicates that the rlcmac/block can be dropped". In the future we could send droppable rlcmac blocks despite there are active TBFs.
For instance if there's 1 DL TBF and no UL TBF and the PCU keeps open the DL TBF for a while after sending last data and it has already been acked.

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I2bf5271c4f1eaf5a975129f73091eb51cee50e57
Gerrit-Change-Number: 24855
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at>
Gerrit-Comment-Date: Tue, 06 Jul 2021 10:07:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list