This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24855 ) Change subject: Do not transmit dummy RLC/MAC blocks on non-BCCH carriers ...................................................................... Patch Set 1: Code-Review-1 (3 comments) https://gerrit.osmocom.org/c/osmo-bts/+/24855/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/24855/1//COMMIT_MSG@11 PS1, Line 11: if a PDCH timeslot has no Uplink nor Downlink TBFs allocated, then (most Dummy blocks can still be sent on DL if there's a TBF available, and they serve a purpose in that case. https://gerrit.osmocom.org/c/osmo-bts/+/24855/1/include/osmo-bts/pcuif_proto.h File include/osmo-bts/pcuif_proto.h: https://gerrit.osmocom.org/c/osmo-bts/+/24855/1/include/osmo-bts/pcuif_proto.h@72 PS1, Line 72: #define PCU_IF_DATA_F_DUMMY (1 << 0) As I mentioned on the other patch, this naming/(description should be changed. https://gerrit.osmocom.org/c/osmo-bts/+/24855/1/src/common/pcu_sock.c File src/common/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bts/+/24855/1/src/common/pcu_sock.c@694 PS1, Line 694: * carriers if the PCU indicates that no TBFs are active at the moment. */ "if the PCU indicates that the rlcmac/block can be dropped". In the future we could send droppable rlcmac blocks despite there are active TBFs. For instance if there's 1 DL TBF and no UL TBF and the PCU keeps open the DL TBF for a while after sending last data and it has already been acked. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24855 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2bf5271c4f1eaf5a975129f73091eb51cee50e57 Gerrit-Change-Number: 24855 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 06 Jul 2021 10:07:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210706/ebf41387/attachment.htm>