Change in osmo-pcu[master]: Indicate to the BTS whether DATA.req contains a dummy block

pespin gerrit-no-reply at lists.osmocom.org
Tue Jul 6 09:49:40 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/24854 )

Change subject: Indicate to the BTS whether DATA.req contains a dummy block
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/24854/2/include/osmocom/pcu/pcuif_proto.h 
File include/osmocom/pcu/pcuif_proto.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/24854/2/include/osmocom/pcu/pcuif_proto.h@74 
PS2, Line 74: #define PCU_IF_DATA_F_DUMMY		(1 << 0)
This is not really true and confusing imho. You are using the flag to mark rlcmac blocks which are safe to drop, not dummy ones. Because some dummy block may contain USF, or may be needed for synchronization procedures, etc.

So better change the name and description of this flag.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/24854
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I72c7f0f0853f2bda77c20e3ec1bcd0c7c815c750
Gerrit-Change-Number: 24854
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 06 Jul 2021 09:49:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210706/2aa2833a/attachment.htm>


More information about the gerrit-log mailing list