Change in osmo-mgw[master]: mgcp_protocol: add support for wildcarded DLCX

neels gerrit-no-reply at lists.osmocom.org
Mon Jul 5 22:13:52 UTC 2021


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24823 )

Change subject: mgcp_protocol: add support for wildcarded DLCX
......................................................................


Patch Set 2:

(2 comments)

Could you give an example of such a wildcard DLCX command?
Like, is it "DLCX rtpbridge/*"?
and it removes all 1 at mgw, 2 at mgw, ... endpoints, each releasing two RTP conns?

So does such a wildcarded DLCX clear out the entire MGW state?
In practice we would then damage the use case of multiple programs using the same osmo-mgw.

E.g. if one osmo-mgw is shared between MSC and BSC, a wildcard DLCX from the BSC would also clear the MSC's conns?

Or imagine two BSCs are using the same osmo-mgw.
If one crashes and restarts, the other also gets all calls dumped.

For a while now I've been having the idea on my mind that osmo-mgw should have an inactivity timeout on endpoints.
When we didn't see any RTP nor MGCP for a long long time (one hour?) then we discard the endpoint implicitly. That would not need a clean wipe from any client program.
one hour: I'd pick a really long time for cases where a call is on hold / mute, or with local-call-local-switch, so that an endpoint can remain inactive for some time to support those use cases.

As I'm writing I'm also getting another idea: we already support using distinct domain names from MGCP clients. For example, I often configure my osmo-msc to use "1 at msc" and the osmo-bsc to use "1 at bsc" domain names in endpoints. If each client of an osmo-mgw has a distinct name (say "@bsc1" and "@bsc2"), it could clear out all its own endpoints like "DLCX *@bsc2" and leave the others intact.

...
Is there a redmine issue describing this? (add "Related:" to commit log?)

...
code wise i'm confused about the role of 'endp' in this patch.
Isn't 'endp' one single "123 at mgw" endpoint? Why does MGCP like "DLCX *@mgw" then go through an 'endp'?

https://gerrit.osmocom.org/c/osmo-mgw/+/24823/2//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-mgw/+/24823/2//COMMIT_MSG@9 
PS2, Line 9: At the moment osmo-mgw does not support wildcarded DLCX requests that
oh wow, i thought we were already using them


https://gerrit.osmocom.org/c/osmo-mgw/+/24823/2/src/libosmo-mgcp/mgcp_protocol.c 
File src/libosmo-mgcp/mgcp_protocol.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/24823/2/src/libosmo-mgcp/mgcp_protocol.c@1341 
PS2, Line 1341: trank
trunk



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24823
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I0770cf46d93ab09efe9cafdd56d2e3f1132db189
Gerrit-Change-Number: 24823
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Jul 2021 22:13:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210705/1e23377d/attachment.htm>


More information about the gerrit-log mailing list