Change in osmo-msc[master]: vlr_sgs: Drop recorded LastEutranPlmnId when UE no longer associated

neels gerrit-no-reply at lists.osmocom.org
Mon Jul 5 21:14:59 UTC 2021


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/24832 )

Change subject: vlr_sgs: Drop recorded LastEutranPlmnId when UE no longer associated
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-msc/+/24832/2/src/libvlr/vlr_sgs_fsm.c 
File src/libvlr/vlr_sgs_fsm.c:

https://gerrit.osmocom.org/c/osmo-msc/+/24832/2/src/libvlr/vlr_sgs_fsm.c@64 
PS2, Line 64: 	vlr_subscr_set_last_used_eutran_plmn_id(vsub, NULL);
looking at the semantics and reading the related issue it seems that immediate removal is not necessarily the right thing to do. Are you sure the intended functionality from "last_used_eutran_plmn_id" is still intact?

does some spec indicate conditions for removal? Maybe a timer or something?

what is the rationale behind clearing upon LU via GERAN?

are you sure to_null() is only called upon LU via GERAN?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/24832
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I0dcb1850ab4f6f7d42bfcb19665ddeae2d3b057a
Gerrit-Change-Number: 24832
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Jul 2021 21:14:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210705/9f9bccc3/attachment.htm>


More information about the gerrit-log mailing list