Change in osmo-bts[master]: osmo-bts-trx: send dummy FACCH in the absense of RTP frames

fixeria gerrit-no-reply at lists.osmocom.org
Mon Jul 5 20:16:15 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24846 )

Change subject: osmo-bts-trx: send dummy FACCH in the absense of RTP frames
......................................................................


Patch Set 2:

> Patch Set 2: Code-Review+1
> 
> some more verbosity in the commit log and/or a spec reference would definitely make it easier for a reviewer to understand this is the right choice.

I am not aware if this behavior is defined in the specs. at all. More details can be found in the related ticket: I am making osmo-bts-trx behave like nanoBTS. But I agree, the commit message needs to give at least a brief explanation.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24846
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I868afecbcb6890f40c8f146e3ce00e836b794dd3
Gerrit-Change-Number: 24846
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Jul 2021 20:16:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210705/3b72e299/attachment.htm>


More information about the gerrit-log mailing list