Change in osmo-bsc[master]: assignment_fsm: Fix null pointer dereference rx ASSIGNMENT_EV_LCHAN_E...

pespin gerrit-no-reply at lists.osmocom.org
Mon Jul 5 17:07:38 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24848 )

Change subject: assignment_fsm: Fix null pointer dereference rx ASSIGNMENT_EV_LCHAN_ERROR
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/24848/2/src/osmo-bsc/assignment_fsm.c 
File src/osmo-bsc/assignment_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24848/2/src/osmo-bsc/assignment_fsm.c@938 
PS2, Line 938: gsm_lchan_name
> Why not to make this function itself NULL-safe? It could simply return "(null)".
Because it's already used like this in lots of places with the required logic. Anyway, in this specific case it wouldn't make much sense to print "Failed to modify chan null".



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24848
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I23a337d411e857954008c6f8ae60be714509d351
Gerrit-Change-Number: 24848
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Jul 2021 17:07:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210705/8831c018/attachment.htm>


More information about the gerrit-log mailing list