Change in osmo-bsc[master]: vty: fix doc: default value for 'nri bitlen'

neels gerrit-no-reply at lists.osmocom.org
Mon Jul 5 11:04:27 UTC 2021


neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24833 )

Change subject: vty: fix doc: default value for 'nri bitlen'
......................................................................

vty: fix doc: default value for 'nri bitlen'

The constant is called OSMO_NRI_BITLEN_DEFAULT, NRI_BITLEN_DEFAULT does
not exist and got rendered as "NRI_BITLEN_DEFAULT" in the vty doc.

Add missing vty test for 'nri bitlen'.

Change-Id: I8af840a4589f47eaca6bf10e37e0859f9ae53dfa
---
M src/osmo-bsc/bsc_vty.c
M tests/nri_cfg.vty
2 files changed, 14 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index 8ba55e6..7207341 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -2326,7 +2326,7 @@
 	   "nri bitlen <1-15>",
 	   NRI_STR
 	   "Set number of bits that an NRI has, to extract from TMSI identities (always starting just after the TMSI's most significant octet).\n"
-	   "bit count (default: " OSMO_STRINGIFY_VAL(NRI_BITLEN_DEFAULT) ")\n",
+	   "bit count (default: " OSMO_STRINGIFY_VAL(OSMO_NRI_BITLEN_DEFAULT) ")\n",
 	   CMD_ATTR_IMMEDIATE)
 {
 	struct gsm_network *gsmnet = gsmnet_from_vty(vty);
diff --git a/tests/nri_cfg.vty b/tests/nri_cfg.vty
index 8287eab..d3db3c8 100644
--- a/tests/nri_cfg.vty
+++ b/tests/nri_cfg.vty
@@ -79,6 +79,19 @@
  nri add 1024 1025
 
 OsmoBSC(config)# network
+
+OsmoBSC(config-net)# list
+...
+  nri bitlen <1-15>
+...
+
+OsmoBSC(config-net)# nri ?
+  bitlen  Set number of bits that an NRI has, to extract from TMSI identities (always starting just after the TMSI's most significant octet).
+  null    Define NULL-NRI values that cause re-assignment of an MS to a different MSC, for MSC pooling.
+
+OsmoBSC(config-net)# nri bitlen ?
+  <1-15>  bit count (default: 10)
+
 OsmoBSC(config-net)# nri bitlen 11
 OsmoBSC(config-net)# show running-config
 ...

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24833
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I8af840a4589f47eaca6bf10e37e0859f9ae53dfa
Gerrit-Change-Number: 24833
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210705/4dd11c27/attachment.htm>


More information about the gerrit-log mailing list