Change in osmo-bsc[master]: power_control: implement BCCH carrier power reduction operation

fixeria gerrit-no-reply at lists.osmocom.org
Fri Jul 2 16:44:17 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24777 )

Change subject: power_control: implement BCCH carrier power reduction operation
......................................................................


Patch Set 4:

(12 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/24777/3//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-bsc/+/24777/3//COMMIT_MSG@14 
PS3, Line 14: However, in the recent 3GPP TS 45.008 there is a feature called
> (could be nice to mention the spec version nr)
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/24777/3//COMMIT_MSG@30 
PS3, Line 30: A value greater than zero would make osmo-bts reduce the power
> what do you mean, "would"?
Rephrased.


https://gerrit.osmocom.org/c/osmo-bsc/+/24777/3/doc/manuals/chapters/power_control.adoc 
File doc/manuals/chapters/power_control.adoc:

https://gerrit.osmocom.org/c/osmo-bsc/+/24777/3/doc/manuals/chapters/power_control.adoc@334 
PS3, Line 334: a BTS shall maintain discontinuous Downlink transmission at full power in order to
> (are you sure that you don't mean "continuous")
Good catch, thanks!


https://gerrit.osmocom.org/c/osmo-bsc/+/24777/3/doc/manuals/chapters/power_control.adoc@337 
PS3, Line 337: version 13.0.0 (2015-11) - "BCCH carrier power reduction operation".
> "in version"
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/24777/3/doc/manuals/chapters/power_control.adoc@348 
PS3, Line 348: and the simulation results can be found in 3GPP TR 45.926.
> ("TS"?)
It's a Technical Report, everything is correct here.


https://gerrit.osmocom.org/c/osmo-bsc/+/24777/3/doc/manuals/chapters/power_control.adoc@352 
PS3, Line 352: At the moment of writing this manual, the only BTS model that can instructed to
> (the usual expression is "at the time of writing") […]
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/24777/3/doc/manuals/chapters/power_control.adoc@354 
PS3, Line 354: can be added on request
> sounds like it doesn't belong in this manual? […]
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/24777/3/doc/manuals/chapters/power_control.adoc@358 
PS3, Line 358: `show bts` command in the VTY interface.
> maybe "in OsmoBSC's VTY interface"
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/24777/3/doc/manuals/chapters/power_control.adoc@363 
PS3, Line 363: There is currently no logic in osmo-bsc for automatic activation and deactivation
> (technically "osmo-bsc" is the binary and here it should be OsmoBSC ... […]
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/24777/3/doc/manuals/chapters/power_control.adoc@407 
PS3, Line 407: 3652121201381481804
> maybe rather make it "1" ? otherwise it looks like a meaningful important number
Not sure if we even have such short numbers on the CTRL interface, isn't it always something like this?


https://gerrit.osmocom.org/c/osmo-bsc/+/24777/3/src/osmo-bsc/bsc_ctrl_commands.c 
File src/osmo-bsc/bsc_ctrl_commands.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24777/3/src/osmo-bsc/bsc_ctrl_commands.c@555 
PS3, Line 555: 	const int red = atoi(value);
> atoi() is not sufficient to verify proper input. […]
To be fair, I don't think we should be paranoid here. Yes, atoi() would accept everything without returning an error. But this would not crash osmo-bsc either. And the CTRL response would contain actually applied value.


https://gerrit.osmocom.org/c/osmo-bsc/+/24777/3/src/osmo-bsc/bts_osmobts.c 
File src/osmo-bsc/bts_osmobts.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24777/3/src/osmo-bsc/bts_osmobts.c@65 
PS3, Line 65: 	dh->chan_nr = RSL_CHAN_BCCH;
> in the commit log you're saying this is abusing the message? […]
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24777
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I047fce33d4d3e4c569dd006ba17858467a2f4783
Gerrit-Change-Number: 24777
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 02 Jul 2021 16:44:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210702/69a3bc94/attachment.htm>


More information about the gerrit-log mailing list