This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24825 ) Change subject: gprs_ns2: fix check of MTU changes for frame relay ...................................................................... Patch Set 3: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/24825/3/src/gb/gprs_ns2_fr.c File src/gb/gprs_ns2_fr.c: https://gerrit.osmocom.org/c/libosmocore/+/24825/3/src/gb/gprs_ns2_fr.c@606 PS3, Line 606: return; looks like this function may need to be changed to return error codes? https://gerrit.osmocom.org/c/libosmocore/+/24825/3/src/gb/gprs_ns2_fr.c@607 PS3, Line 607: mtu -= 2; having mtu this way is a bit confusing, I'd welcome changing the name to make it easier to follow what's counted inside this MTU. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24825 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I02d4e81896a473aeb79ea2f2983e12324244048f Gerrit-Change-Number: 24825 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 02 Jul 2021 15:23:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210702/170a924f/attachment.htm>