Change in libosmocore[master]: gprs_ns2_vc_fsm: rename state UNCONFIGURED -> DISABLED

lynxis lazus gerrit-no-reply at lists.osmocom.org
Fri Jul 2 14:43:50 UTC 2021


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24685 )

Change subject: gprs_ns2_vc_fsm: rename state UNCONFIGURED -> DISABLED
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> I'm not sure/convinced that 'unconfigured' is a wrong name.  Why would "unconfigured" only happen at start-up?  What event is causing it to become unconfigured later on again, and why is the name wrong? Is it still in some way "configured" while in that state?

Original the unconfigured was just the initial state. Later a vty command for testing was introduced. And now the frame relay is forcing all NSVC into the unconfigured state when the DLCI become unavailable.


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24685
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I5f46ce5e27d7556d5e17bc236f1765d42aecbe0c
Gerrit-Change-Number: 24685
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 02 Jul 2021 14:43:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210702/1f1f122e/attachment.htm>


More information about the gerrit-log mailing list