Change in libosmocore[master]: ns2: Use named array initializers to avoid mistakes

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Jan 31 11:35:04 UTC 2021


Hello Jenkins Builder, daniel, lynxis lazus, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/libosmocore/+/22556

to look at the new patch set (#2).

Change subject: ns2: Use named array initializers to avoid mistakes
......................................................................

ns2: Use named array initializers to avoid mistakes

It's always a bad idea to have an array of descriptions that's indexed
by an enum, without using named initializers.  It's too easy to get
inconsistencies.

Change-Id: Id0ebd2a202a465ca0298f4245f1fb5c495235fc8
---
M src/gb/gprs_ns2.c
M src/gb/gprs_ns2_internal.h
M src/gb/gprs_ns2_message.c
3 files changed, 27 insertions(+), 30 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/56/22556/2
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22556
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id0ebd2a202a465ca0298f4245f1fb5c495235fc8
Gerrit-Change-Number: 22556
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210131/7cd5935a/attachment.htm>


More information about the gerrit-log mailing list