This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22510 )
Change subject: lchan assignment when RTP is set up: don't break on Mode Modify
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/c/osmo-bsc/+/22510/1/src/osmo-bsc/assignment_fsm.c
File src/osmo-bsc/assignment_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/22510/1/src/osmo-bsc/assignment_fsm.c@442
PS1, Line 442: && !conn->lchan->fi_rtp) {
> i like it when completely unrelated conditions are on a separate line
well, but it definitely is not how we generally write code in osmocom. But not a blocker.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22510
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I06d3f35fcc71d77e1f30c2b15ab221ef7d5f7f27
Gerrit-Change-Number: 22510
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Jan 2021 21:19:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210129/c4fb0f66/attachment.htm>