This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/22314 ) Change subject: gbproxy: WIP RIM support ...................................................................... Patch Set 2: (3 comments) https://gerrit.osmocom.org/c/osmo-sgsn/+/22314/2/src/gbproxy/gb_proxy.c File src/gbproxy/gb_proxy.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/22314/2/src/gbproxy/gb_proxy.c@953 PS2, Line 953: insure ensure https://gerrit.osmocom.org/c/osmo-sgsn/+/22314/2/src/gbproxy/gb_proxy.c@969 PS2, Line 969: } > Yeah, but we might talk to a (3rd party) SGSN that supports other protocols. […] Definitely, gbproxy should simply forward anything != GERAN to the SGSN and let the SGSN deal with it. https://gerrit.osmocom.org/c/osmo-sgsn/+/22314/2/src/gbproxy/gb_proxy.c@1275 PS2, Line 1275: insure "ensure". And why would we want to check the RIM Source address here? If it's from the SGSN, we don't care which is the source address (not even whether it's GERAN). We just care about the destination, which must be within the cells covered by this gbproxy. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/22314 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I3403736eed9d6819634c26db0b90393ac6f4416a Gerrit-Change-Number: 22314 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann at sysmocom.de> Gerrit-Assignee: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: dexter <pmaier at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Fri, 29 Jan 2021 21:13:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann at sysmocom.de> Comment-In-Reply-To: dexter <pmaier at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210129/4cbf2900/attachment.htm>