Change in osmo-ttcn3-hacks[master]: GBProxy_Tests: fix TC_rim_* tests

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22525 )

Change subject: GBProxy_Tests: fix TC_rim_* tests
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22525/2/library/Osmocom_Gb_Types.ttcn 
File library/Osmocom_Gb_Types.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22525/2/library/Osmocom_Gb_Types.ttcn@2978 
PS2, Line 2978: 		 ret.lengthIndicator := { length1 := ? };
> Formatting is different here. […]
for sure a function has different syntax than a template.  But insid the function you could still have

... ret := {
  iEi := '56'O,
  ext := '1'B,
  lengthIndicator := {
    length1 := ?
  },
  nACC_cause := -,
  erroneousApplicationContainer := app_cont
}

and then the if clause that sets nACC_cause to a template or whatever.

I don't really see much advantage either way.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22525
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie484f288aa0515ef4df4a3cf7f8a347a3f3cf587
Gerrit-Change-Number: 22525
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 29 Jan 2021 08:54:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: daniel <dwillmann at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210129/066ae482/attachment.htm>