Change in osmo-pcu[master]: gprs_ns2: migrate to the new vty syntax

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Thu Jan 28 21:10:45 UTC 2021


lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22507 )

Change subject: gprs_ns2: migrate to the new vty syntax
......................................................................

gprs_ns2: migrate to the new vty syntax

This also changes the vty configuration. If only timeout has been
configured for ns the new configuration is compatible.

For further information see:
https://osmocom.org/projects/libosmocore/wiki/Network_service_(NS)

Depends-on: I8c3f2afecc74b78f7f914f7dce166cbcb63444eb (libosmocore)
Change-Id: I14af821a8d1fda670643c3d5f81299a3abf3c583
---
M src/pcu_main.cpp
1 file changed, 1 insertion(+), 3 deletions(-)

Approvals:
  daniel: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/pcu_main.cpp b/src/pcu_main.cpp
index ea7e341..003cabb 100644
--- a/src/pcu_main.cpp
+++ b/src/pcu_main.cpp
@@ -270,7 +270,7 @@
 		exit(1);
 	}
 	bssgp_set_bssgp_callback(gprs_gp_send_cb, pcu->nsi);
-	gprs_ns2_vty_init(pcu->nsi, NULL);
+	gprs_ns2_vty_init(pcu->nsi);
 
 	rc = vty_read_config_file(config_file, NULL);
 	if (rc < 0 && config_given) {
@@ -282,8 +282,6 @@
 		fprintf(stderr, "No config file: '%s' Using default config.\n",
 			config_file);
 
-	gprs_ns2_vty_create();
-
 	rc = telnet_init_dynif(tall_pcu_ctx, NULL, vty_get_bind_addr(),
 			       OSMO_VTY_PORT_PCU);
 	if (rc < 0) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22507
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I14af821a8d1fda670643c3d5f81299a3abf3c583
Gerrit-Change-Number: 22507
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210128/f2b94407/attachment.htm>


More information about the gerrit-log mailing list