Change in osmo-ttcn3-hacks[master]: PCU_Tests: add testcase TC_rim_ran_info_req_single_rep and _no_si

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Jan 25 18:12:10 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369 )

Change subject: PCU_Tests: add testcase TC_rim_ran_info_req_single_rep and _no_si
......................................................................


Patch Set 2: Code-Review-1

(4 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/2/library/Osmocom_Gb_Types.ttcn 
File library/Osmocom_Gb_Types.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/2/library/Osmocom_Gb_Types.ttcn@2814 
PS2, Line 2814: 	function tr_RAN_Information_Application_Container_NACC(template BssgpCellId cid := ?, template boolean psi_type := ?,
You probably want to push all these templates and functions as a separate patch


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/2/library/PCUIF_Types.ttcn 
File library/PCUIF_Types.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/2/library/PCUIF_Types.ttcn@229 
PS2, Line 229: 	variant (trx) "CROSSTAG(v09, version = 10; v10, version = 11)"
these lines changed here look wrong to me.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/2/pcu/PCU_Tests.ttcn 
File pcu/PCU_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/2/pcu/PCU_Tests.ttcn@3659 
PS2, Line 3659: 	f_init_raw(testcasename());
you can pass info_ind as a second parameter here, no need to do the BTS.send() below.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/2/pcu/PCU_Tests.ttcn@3717 
PS2, Line 3717: 	f_sleep(0.2); /* i.e. give the IUT some time to process everything */
which is exactly the problem you are having here?

BTW, since you are not using rlcmac or itneracting with any MS at all here, I'd say the test maybe belongs more to the PCU_Tests_NS or similar rather than here?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9054ab0e969c0fbfdc671c92d44cc61360959adc
Gerrit-Change-Number: 22369
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 25 Jan 2021 18:12:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210125/98584d71/attachment.htm>


More information about the gerrit-log mailing list