Change in osmo-ttcn3-hacks[master]: PCU_Tests: add testcase TC_rim_ran_info_req_single_rep and _no_si

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Jan 25 15:32:18 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369 )

Change subject: PCU_Tests: add testcase TC_rim_ran_info_req_single_rep and _no_si
......................................................................


Patch Set 1:

Hi Philipp,

> Patch Set 1:
> 
> > Patch Set 1: Code-Review-2
> > 
> > We cannot just bump the protocol version here, as we also need to test the 'latest' osmo-pcu. See my comments to the related changes for osmo-pcu.
> 
> I have seen we have a module parameter for the version number and we always support the current version number and the latest. If we can not bumb the version number here, where else can we bump it and don't we have to bump it if we modify indications?

bumping the version is not enough, you also need to change the protocol definition in a way that it's possible to encode/decode messages for the old and the new versions. It would be a lot easier to introduce a new PCUIF message for sending System Information, instead of (ab)using INFO.ind for that. This way you can keep using the current protocol version, older IUT would just ignore/reject these new messages.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9054ab0e969c0fbfdc671c92d44cc61360959adc
Gerrit-Change-Number: 22369
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 25 Jan 2021 15:32:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210125/e946b0ce/attachment.htm>


More information about the gerrit-log mailing list