Change in osmo-pcu[master]: tbf: Drop always-true condition checking for MS

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Jan 25 12:44:33 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22420 )

Change subject: tbf: Drop always-true condition checking for MS
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/22420/3//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-pcu/+/22420/3//COMMIT_MSG@12 
PS3, Line 12: isctually
?


https://gerrit.osmocom.org/c/osmo-pcu/+/22420/3//COMMIT_MSG@21 
PS3, Line 21: Hence, it is safe to drop those checks for MS not being null. Those
you could also OSMO_ASSERT(m_ms) instead. Not saying you must...



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22420
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: If292a53a09a64664031e756bff4735b9c6ee8651
Gerrit-Change-Number: 22420
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 25 Jan 2021 12:44:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210125/05c5ac00/attachment.htm>


More information about the gerrit-log mailing list