This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22420 ) Change subject: tbf: Drop always-true condition checking for MS ...................................................................... tbf: Drop always-true condition checking for MS TBF is always attached to an MS object (despite the MS object can change over time due to MS objects being merged when found duplicate upon receiving new info). Hence, it makes no sense to check if the TBF is attached. If it's not, then it's a bug. Change-Id: If292a53a09a64664031e756bff4735b9c6ee8651 --- M src/tbf.cpp 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/20/22420/1 diff --git a/src/tbf.cpp b/src/tbf.cpp index 37af21f..cfc13df 100644 --- a/src/tbf.cpp +++ b/src/tbf.cpp @@ -196,9 +196,9 @@ enum CodingScheme cs; if (direction == GPRS_RLCMAC_UL_TBF) - cs = m_ms ? ms_current_cs_ul(m_ms) : UNKNOWN; + cs = ms_current_cs_ul(m_ms); else - cs = m_ms ? ms_current_cs_dl(m_ms) : UNKNOWN; + cs = ms_current_cs_dl(m_ms); return cs; } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22420 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If292a53a09a64664031e756bff4735b9c6ee8651 Gerrit-Change-Number: 22420 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210125/90793bf5/attachment.htm>