Change in osmo-bts[master]: l1sap: include Uplink RSSI in GSMTAP packets

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sat Jan 23 20:58:15 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/22393 )

Change subject: l1sap: include Uplink RSSI in GSMTAP packets
......................................................................

l1sap: include Uplink RSSI in GSMTAP packets

Change-Id: I99a257c0320b08b62270a35796bee7f8e862e3ab
Related: SYS#5073
---
M src/common/l1sap.c
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index eb610dc..1542c8a 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -505,6 +505,7 @@
 	uint8_t chan_type = 0, tn = 0, ss = 0;
 	uint32_t fn;
 	uint16_t uplink = GSMTAP_ARFCN_F_UPLINK;
+	int8_t signal_dbm;
 	int rc;
 
 	if (!gsmtap)
@@ -523,10 +524,12 @@
 		else
 			rc = gsmtap_ph_data(l1sap, &chan_type, &ss, fn, &data,
 					    &len, num_agch(trx, "GSMTAP"));
+		signal_dbm = l1sap->u.data.rssi;
 		break;
 	case OSMO_PRIM(PRIM_PH_RACH, PRIM_OP_INDICATION):
 		rc = gsmtap_ph_rach(l1sap, &chan_type, &tn, &ss, &fn, &data,
 			&len);
+		signal_dbm = l1sap->u.rach_ind.rssi;
 		break;
 	default:
 		rc = -ENOTSUP;
@@ -550,8 +553,8 @@
 	if (is_fill_frame(chan_type, data, len))
 		return 0;
 
-	gsmtap_send(gsmtap, trx->arfcn | uplink, tn, chan_type, ss, fn, 0, 0,
-		data, len);
+	gsmtap_send(gsmtap, trx->arfcn | uplink, tn, chan_type, ss, fn,
+		    signal_dbm, 0 /* TODO: SNR */, data, len);
 
 	return 0;
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/22393
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I99a257c0320b08b62270a35796bee7f8e862e3ab
Gerrit-Change-Number: 22393
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210123/42f0723a/attachment.htm>


More information about the gerrit-log mailing list