This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/22110 ) Change subject: sgsn_rim: Add routing for (GERAN) BSSGP RIM messages ...................................................................... Patch Set 4: (2 comments) I would also add some logging. * LOGL_DEBUG whenever RIM is received + transmitted? * LOGL_NOTICE whenever a destination cannot be found? https://gerrit.osmocom.org/c/osmo-sgsn/+/22110/4/src/sgsn/sgsn_rim.c File src/sgsn/sgsn_rim.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/22110/4/src/sgsn/sgsn_rim.c@49 PS4, Line 49: retu shouldn't we return a RIM-ERROR or RIM-APPLICATION-ERROR here? IMHO RIM is really one layer above/inside BSSGP, so a BSSGP STATUS doesn't look like the best response. https://gerrit.osmocom.org/c/osmo-sgsn/+/22110/4/src/sgsn/sgsn_rim.c@54 PS4, Line 54: retu likewise here. Isn't there some RIM specific error we can return indicationg that the destination doesn't exist? -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/22110 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I6fde8ab8955660b48000ca1b650cfc7c7b2e24ba Gerrit-Change-Number: 22110 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Fri, 22 Jan 2021 19:57:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210122/f1630061/attachment.htm>