This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22364 ) Change subject: Initial handling support for RIM messages ...................................................................... Patch Set 3: Code-Review-1 (4 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/22364/3/src/gprs_bssgp_pcu.c File src/gprs_bssgp_pcu.c: https://gerrit.osmocom.org/c/osmo-pcu/+/22364/3/src/gprs_bssgp_pcu.c@a554 PS3, Line 554: break; Looks like this break was not removed intentionally, handle_rim() will assert on SAP_BSSGP_NM. https://gerrit.osmocom.org/c/osmo-pcu/+/22364/3/src/gprs_bssgp_rim.c File src/gprs_bssgp_rim.c: https://gerrit.osmocom.org/c/osmo-pcu/+/22364/3/src/gprs_bssgp_rim.c@91 PS3, Line 91: certian (certain) https://gerrit.osmocom.org/c/osmo-pcu/+/22364/3/src/gprs_bssgp_rim.c@127 PS3, Line 127: /* FIXME: send RIM error instead */ If I read the spec right (8c.3.1.2 as mentioned above), it wants you to send a STATUS PDU, not a RIM PDU. That would mean the fixme isn't needed. EDIT: just saw the discussion before, maybe elaborate in the FIXME why we want a RIM PDU instead of STATUS PDU then, although spec says otherwise? https://gerrit.osmocom.org/c/osmo-pcu/+/22364/3/src/gprs_bssgp_rim.c@161 PS3, Line 161: failes (fails) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia0ade0e97ea781ec655439c008b6cefaf3e90dec Gerrit-Change-Number: 22364 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Fri, 22 Jan 2021 14:41:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210122/359be8f1/attachment.htm>